[Feature] Add Discord notifications for threshold failures with user mentions#1898
[Feature] Add Discord notifications for threshold failures with user mentions#1898rubencosta13 wants to merge 3 commits intoalexjustesen:mainfrom
Conversation
|
I didn't like how the UI turned out to be, possibly a WIP for me... |
|
my two cents, would not be nicer to have the Discord User id as part of the |
Yup, kinda makes more sense! TY |
|
Then you also don't need the separate settings for it as it will be saved in the json with the discord url :) |
| ->label('User ID') | ||
| ->placeholder('Enter the Discord User ID') | ||
| ->maxLength(18) | ||
| ->helperText('This should be the numeric User ID from Discord (e.g., 123456789012345678)'), |
There was a problem hiding this comment.
Instead of using the helperText can you add a hint that says "Get User ID" with a link out to the Discord docs here: https://support.discord.com/hc/en-us/articles/206346498-Where-can-I-find-my-User-Server-Message-ID#h_01HRSTXPS5H5D7JBY2QKKPVKNA
| @@ -1,5 +1,9 @@ | |||
| **Speedtest Threshold Breached - #{{ $id }}** | |||
|
|
|||
| @if (!empty($mentionUser)) | |||
There was a problem hiding this comment.
Not required but you could also use the new @blank and @filled directives merged in #1951.
|
@rubencosta13 if you still want to merge this in just a small change to help with finding a user's ID in Discord. If you no longer want to merge feel free to close the PR. |
Will do it this week! |
|
Closing as it's been a month, feel free to open a new PR with updates when you're ready. |
3 participants
📃 Description
This pull request introduces a new feature to notify Discord users when a speedtest threshold is breached. The notifications include the breached metric details and support user mentions in Discord.
🪵 Changelog
➕ Added
✏️ Changed
📷 Screenshots